How to detect a profit amount of a position in MQL5?

Order Management
#1

Hi there, the title says it all…In my EA (MT5) when the robot is closing position I want to check the profit of current position properly. I know there is a function “PositionGetDouble” but am not sure about how to use it properly. On my ECN account I pay commisions for each position opening cca. $2/lot + each position closing, totaling $4/lot. Besides that there may be positive or negative swap calculated.

So my question is how can I calculate my net profit for a certain position?

double x = PositionGetDouble(POSITION_PROFIT);

double y = PositionGetDouble(POSITION_SWAP);

Is variable “x” my net profit, or should I subtract variable “y” and commission which I don’t yet know where to get from.

Please suggest, much thanks in advance for your help.

#2 
double GetPositionCommission( void )
{
  double Commission = ::PositionGetDouble(POSITION_COMMISSION);

  // На случай, если POSITION_COMMISSION не работает
  if (Commission == 0)
  {
    const ulong Ticket = GetPositionDealIn();

    if (Ticket > 0)
    {
      const double LotsIn = ::HistoryDealGetDouble(Ticket, DEAL_VOLUME);

      if (LotsIn > 0)
        Commission = ::HistoryDealGetDouble(Ticket, DEAL_COMMISSION) * ::PositionGetDouble(POSITION_VOLUME) / LotsIn;
    }
  }

  return(Commission);
}

 ulong GetPositionDealIn( const ulong PositionIdentifier = 0 )
  {
    ulong Ticket = 0;

    if ((PositionIdentifier == 0) ? ::HistorySelectByPosition(::PositionGetInteger(POSITION_IDENTIFIER)) : ::HistorySelectByPosition(PositionIdentifier))
    {
      const int Total = ::HistoryDealsTotal();

      for (int i = 0; i < Total; i++)
      {
        const ulong TicketDeal = ::HistoryDealGetTicket(i);

        if (TicketDeal > 0)
          if ((ENUM_DEAL_ENTRY)::HistoryDealGetInteger(TicketDeal, DEAL_ENTRY) == DEAL_ENTRY_IN)
          {
            Ticket = TicketDeal;

            break;
          }
      }
    }

    return(Ticket);
  }
#3

thanks, but this way you are getting commision from previous deals which were closed. What if I don’t have them yet, I’m trading multiple instruments with this EA, so there may be no done deals yet at the time I want to close my first one.

Besides, the question about how get “net profit” remains still open. Any other ideas, inputs, clarifications, much welcome.

Thanks in advance

#4

First try!..

#5

Thanks I will, and will report back. In the meantime do you know what is included/excluded in

PositionGetDouble(POSITION_PROFIT);

Much thanks again for your help.

#6

Ok you was right, I can find deals from my current position, once I have the first deal, I can get it’s commision and calculate commision on my position that way, cool.

I still haven’t managed to find out about PositionGetDouble(POSITION_PROFIT), what it actually contans, I’ll do some sample trades with my EA to clear this.

Thanks again.

#7

POSITION_PROFIT = POSITION_VOLUME * SYMBOL_TRADE_TICK_VALUE * (POSITION_PRICE_CURRENT - POSITION_PRICE_OPEN) / SYMBOL_TRADE_TICK_SIZE

ACCOUNT_PROFIT = ACCOUNT_EQUITY - ACCOUNT_BALANCE = Sum(POSITION_PROFIT[i] + POSITION_SWAP[i] + POSITION_COMMISSION[i])

#8

Thanks, I haven’t checked that yet, but from the docs, I see that

SYMBOL_TRADE_TICK_VALUE=Value of SYMBOL_TRADE_TICK_VALUE_PROFIT

SYMBOL_TRADE_TICK_VALUE_PROFIT=Calculated tick price for a profitable position

What is now the a profitable position? Ok in other words, to make long story short, I can reduce question to this:

When I’m calculating net profit for a position which is still open, I use PositionGetDouble(POSITION_PROFIT), but I have to subtract Commision and Swaps? Is this right? Ok, Swaps can also be positive, but just I need just the principle.

Thanks again.

#9

Thanks, i’ve asked about position profit, so just skipped the account profit line you wrote. Anyway I see I’m right, so ok case solved, thanks.